node-oauth2-server icon indicating copy to clipboard operation
node-oauth2-server copied to clipboard

Improve documentation by adding jsDoc compatible method documentations

Open jankapunkt opened this issue 2 years ago • 7 comments

I found many functions lack of proper parameter descriptions, for example in server.js. Especially options are often completely undocumented.

jankapunkt avatar Sep 16 '22 14:09 jankapunkt

Also the README should add a "migrate from 3.x" guide, even if there are no breaking issues

jankapunkt avatar Oct 01 '22 12:10 jankapunkt

@HappyZombies @jorenvandeweyer I have fiddled around with RST but it's a real struggle :see_no_evil:

My proposal would be:

  • use a markdown template and update all guides to markdown-based
  • use jsDoc with jsDoc to markdown to auto-generate API docs
  • use GitHub actions + GitHub pages to auto-publish documentation instead of readthedocs

What do you think?

jankapunkt avatar May 30 '23 15:05 jankapunkt

I agree. I'd suggest using Vitepress! Simple to setup and markdown templates.

jorenvandeweyer avatar May 30 '23 15:05 jorenvandeweyer

If you want I can set it up.

jorenvandeweyer avatar May 30 '23 15:05 jorenvandeweyer

@jorenvandeweyer sounds promising! We can try to work on this on a separate branch. Does it support jsDoc?

jankapunkt avatar May 30 '23 15:05 jankapunkt

@jankapunkt No it does not support jsDoc, do we need it?

jorenvandeweyer avatar Aug 27 '23 13:08 jorenvandeweyer

I think we are good with the current docs for now but in the long run jsDoc is a good way for API docs as the functions are documented in place

jankapunkt avatar Aug 27 '23 13:08 jankapunkt