serialize-json icon indicating copy to clipboard operation
serialize-json copied to clipboard

Do not use external dependencies

Open krasimir opened this issue 8 years ago • 0 comments

Checklist
  • [x] npm test passes
  • [x] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines (I'm not sure where's this guidelines)
Description of change

There were three dependencies debug, is-type-of and utility. debug was I believe for just logs which we don't need in production. utility's has method may be replaced by Object.prototype.hasOwnProperty. is-type-of methods have also simple replacements. I checked the actual implementation of those methods and they're basically doing the same thing. By removing the dependencies we solved our problem which was about increasing the final bundle size (mainly because of the is-type-of's dependency of utils).

krasimir avatar Dec 13 '17 14:12 krasimir