hessian.js icon indicating copy to clipboard operation
hessian.js copied to clipboard

support for long.js

Open lishengguo opened this issue 7 years ago • 5 comments

writeLong(Long.fromValue(7))

lishengguo avatar Aug 25 '17 03:08 lishengguo

@lishengguo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @gxcsoccer and @xusiyuan841028 to be potential reviewers.

mention-bot avatar Aug 25 '17 03:08 mention-bot

Codecov Report

Merging #85 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #85   +/-   ##
======================================
  Coverage    96.1%   96.1%           
======================================
  Files           7       7           
  Lines        1079    1079           
  Branches      204     204           
======================================
  Hits         1037    1037           
  Misses         42      42
Impacted Files Coverage Δ
lib/v2/encoder.js 94.57% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e8cfc6...83f6531. Read the comment docs.

codecov[bot] avatar Aug 25 '17 03:08 codecov[bot]

any test cases?

fengmk2 avatar Oct 18 '17 03:10 fengmk2

add test case : Long.fromNumber(0)

lishengguo avatar Oct 19 '17 07:10 lishengguo

Please rebase from master branch.

fengmk2 avatar Aug 02 '18 13:08 fengmk2