gh-jira icon indicating copy to clipboard operation
gh-jira copied to clipboard

Error running `gh ji`

Open jwu910 opened this issue 6 years ago • 5 comments

TypeError: Cannot read property 'user' of undefined
    at Jira.normalizeOptions (/home/joshua/.nvm/versions/node/v10.16.0/lib/node_modules/gh-jira/bin/jira.js:775:59)
    at Jira.run (/home/joshua/.nvm/versions/node/v10.16.0/lib/node_modules/gh-jira/bin/jira.js:180:14)
    at getCommand.fork (/home/joshua/.nvm/versions/node/v10.16.0/lib/node_modules/gh/lib/cmd.js:175:39)

@protoEvangelion is gh-jira not compatible with recent releases of node-gh?

I just updated gh to 2.8.3 but gh-jira is still at 1.0.7.

I haven't been able to get gh-jira to work with node-gh in a while. Has this been on the radar? I vaguely remember the security changes that were made to the JIRA server we use caused issues in the past, but wondering that was a one time fluke or if it's a reproducible problem.

Thanks!

jwu910 avatar Dec 17 '19 22:12 jwu910

Hey @jwu910 👋 I haven't been maintaining gh-jira, for a while, however I did test it successfully for v2 of gh with a manual workaround.

I'm pretty sure your issues have something to do with Jira's required oauth handshake. In the past we could just send over basic auth (user & pass) but they don't allow that method of auth any more.

Let me know if you have any ideas of how to approach this!

protoEvangelion avatar Dec 23 '19 18:12 protoEvangelion

I haven't worked with this type of functionality yet, and am interested, but at this moment--no ideas, sorry.

I remember this came up when we made changes to our JIRA auth, so maybe it's still a problem. Not that big a issue. You can close this or maybe consider a request for comments/help wanted

jwu910 avatar Dec 23 '19 18:12 jwu910

That sounds about right. Thanks for raising the issue! I'll leave it open.

protoEvangelion avatar Dec 23 '19 18:12 protoEvangelion

Side note, I'm actually thinking of deprecating this plugin along with the concept of plugins. The same thing can be accomplished through hooks (ie state sharing). Any thoughts?

protoEvangelion avatar Mar 05 '20 00:03 protoEvangelion

I dont think its a critical package, it's a great workflow benefit, but it was really only saving a couple clicks. I think post-PR scripts with gh can help partially automate the use case I wanted to solve anyways.

Thanks for the consideration! Hope all is well!

Feel free to close

jwu910 avatar Mar 06 '20 16:03 jwu910