formidable icon indicating copy to clipboard operation
formidable copied to clipboard

Upload dir async

Open GrosSacASac opened this issue 3 years ago • 5 comments

For some reason parse callback is never called, I did not yet figure out why

GrosSacASac avatar May 18 '22 16:05 GrosSacASac

@wbt and @Akxe have another look, it works now

The thing I forgot initially when moving to async, is I have to await for a directory to be created and then let the actual file that has that directory destination continue

@wbt I would be curious what the code you made looked like

GrosSacASac avatar Jun 15 '22 14:06 GrosSacASac

@wbt I would be curious what the code you made looked like

It had client-side recursive iteration that sent several requests to the server, one for each folder creation and file upload. The server side did path validation (including checking for attempts to walk up the directory tree) etc.

wbt avatar Jul 14 '22 18:07 wbt

@wbt thanks for sharing

GrosSacASac avatar Jul 14 '22 21:07 GrosSacASac

It might be helpful to add some documentation updates with this PR too.

wbt avatar Jul 18 '22 16:07 wbt

It might be helpful to add some documentation updates with this PR too.

@wbt Added a note in the readme

Published https://www.npmjs.com/package/@grossacasacs/formidable here so I can test it for a while

GrosSacASac avatar Jul 20 '22 13:07 GrosSacASac

@tommyhtran please help to review this PR

GrosSacASac avatar Nov 30 '22 14:11 GrosSacASac

Thanks for the review, I will add a few more tests then merge

GrosSacASac avatar Dec 05 '22 15:12 GrosSacASac

All the test pass now ;) But they don't even run in github actions ... Published as 3.3.2

GrosSacASac avatar Jun 16 '23 11:06 GrosSacASac