Stockfish icon indicating copy to clipboard operation
Stockfish copied to clipboard

Published 20 hours ago • verified publisher icon nodchip

race conditions in the code.

Open vondele opened this issue 5 years ago • 5 comments

current gensfen and learn commands are not correct multithreaded, several races remain. To check:

make clean && make -j2 ARCH=x86-64-modern sanitize=thread    optimize=no debug=yes build > /dev/null && ../tests/instrumented_learn.sh --sanitizer-thread

vondele avatar Sep 20 '20 17:09 vondele

@Sopel97 maybe you can test if this is fixed by adding that line to .travis.yml ?

vondele avatar Sep 25 '20 14:09 vondele

@nodchip @Sopel97 this was auto-closed on merge, maybe we can explicitly add the line above to CI, to make sure it is fixed.

vondele avatar Oct 21 '20 10:10 vondele

Right, not sure why this was closed straight up. There may still be issues in gensfen. I'd reopen this for now, later I'll try adding the CI tasks when I reduce the bench depth in valgrind.

Sopel97 avatar Oct 21 '20 12:10 Sopel97

doesn't look like I can reopen @nodchip should have the permission to do that.

github will auto-close issues if the commit message says fixes #1234 unfortunately also for 'maybe fixes' 'partially fixes' etc.

vondele avatar Oct 21 '20 12:10 vondele

I reopened this issue.

nodchip avatar Oct 21 '20 12:10 nodchip