Stockfish icon indicating copy to clipboard operation
Stockfish copied to clipboard

Establish the standard process to introduce new features in machine learning repository (this repository)

Open nodchip opened this issue 5 years ago • 0 comments

We could be better to establish the standard process to introduce new features in this repository. The objective of the process is:

  • Simplify the process.
  • Avoid evaluation dependent on individual skills.
  • Avoid regressions.
  • Avoid bad changes which decrease the elo.

My current suggestion is:

  1. Discuss in Discord.
  2. Create a pull request to implement a new feature.
    • In this timing, the new feature should be disabled by an option.
  3. Create an issue to experiment the new feature.
    • In the experiment, we should record and share the experiment environment (OS, CPU, Memory, ...), all the commands and the results.
    • fishtest is used to compare the elos.
  4. Create a pull request to enable the new feature by default, and update documents (Readme.md, etc...).

I created example issues about 3.

  • https://github.com/nodchip/Stockfish/issues/135
  • https://github.com/nodchip/Stockfish/issues/136
  • https://github.com/nodchip/Stockfish/issues/137
  • https://github.com/nodchip/Stockfish/issues/138

I'd like to hear other's opinions. Any comments are welcome.

nodchip avatar Sep 11 '20 06:09 nodchip