SHARK icon indicating copy to clipboard operation
SHARK copied to clipboard

SHARK Stable Release Tracker (12/2023)

Open monorimet opened this issue 2 years ago • 9 comments

Adding a list of TODOs:

  • [x] MultiControlNet

    • [x] resize input image(s) to desired output size
    • [x] verify correctness of pipeline structure -- are we using the right unet weights?
    • [x] enable "controlnet t2i adaptation", i.e. t2i with controlnet adapters ( ? )
    • [x] zoedepth import doesn't work
    • [x] stencil canvas isn't centered in image editor
  • [ ] SDXL

    • [ ] LoRAs
    • [ ] vulkan issues with SDXL-1.0 1024x1024
    • [ ] controlnet
    • [ ] verify guidance scale implem.
  • [x] fix nod logo

  • [x] fix UX regressions caused by gradio version update

monorimet avatar Dec 04 '23 19:12 monorimet

can we have sdxl turbo too added?

countradooku avatar Dec 05 '23 09:12 countradooku

can we have sdxl turbo too added?

Done. https://github.com/nod-ai/SHARK/releases/tag/20231205.1064

monorimet avatar Dec 05 '23 17:12 monorimet

image i get this on rx 7900xtx on default settings on sd xl turbo

countradooku avatar Dec 05 '23 18:12 countradooku

@monorimet

countradooku avatar Dec 05 '23 18:12 countradooku

@monorimet Now I've got my LoRA changes vaguely into shape, I'll take a look the nod-ai logo and the gradio update regressions.

EDIT: /em looks at time, sometime tomorrow if no-one has picked them up.

one-lithe-rune avatar Dec 05 '23 21:12 one-lithe-rune

@monorimet it works nevermind

countradooku avatar Dec 06 '23 07:12 countradooku

When switching to sdxl-turbo, it disables the positive prompt, leaving only the negative one. Instead, I have to write the prompt while in sdxl-base mode, then switch to turbo.

mergmann avatar Dec 09 '23 21:12 mergmann

The sdxl-turbo model works mostly fine for me, but trying to run sdxl-base results in SystemExit: SharkifyStableDiffusionModel.get_unet_sdxl.<locals>.UnetModel.forward() missing 2 required positional arguments: 'time_ids' and 'guidance_scale' OS: EndeavourOS/Arch Linux GPU: RX 7900 XT (using amdvlk as mesa/vulkan-radeon is broken) Settings: 512x512 50 steps

mergmann avatar Dec 09 '23 21:12 mergmann

When switching to sdxl-turbo, it disables the positive prompt, leaving only the negative one. Instead, I have to write the prompt while in sdxl-base mode, then switch to turbo.

There's something goofy about the inputs/guidance scale for the SDXL implementation. This is actually intended behavior as a quick'n'dirty workaround but it's not a long term solution. I'll add a task for it.

monorimet avatar Dec 10 '23 04:12 monorimet