Nobuyoshi Nakada

Results 159 comments of Nobuyoshi Nakada

```diff diff --git i/ext/-test-/string/set_len.c w/ext/-test-/string/set_len.c index 049da2cdb5c..b55ef6f4691 100644 --- i/ext/-test-/string/set_len.c +++ w/ext/-test-/string/set_len.c @@ -16,9 +16,17 @@ bug_str_append(VALUE str, VALUE addendum) return str; } +static VALUE +bug_str_resize(VALUE str, VALUE len) +{...

What do you mean by "It crashes"? It seems to exit with an error as expected. ```shell-session $ echo '#!ruby --enable' > test.rb $ ruby test.rb ruby: missing argument for...

I agree the basic policy.

> * Interestingly, https://github.com/ruby/monitor is archived. Should this gem be removed from [`./ext/monitor`](https://github.com/ruby/ruby/tree/master/ext/monitor) in this repo? It was moved there once, but partially rewritten as an extension library at #2576....

Not for this method directly; more usage of `UnboundMethod#bind_call` to call an overridden method may be useful.

It is a trade-off between `setjmp` and a temporary object. Another idea is to merge it with `ruby_getcwd`. ```diff diff --git i/dir.c w/dir.c index ce5a90ebf7b..4d503facd9c 100644 --- i/dir.c +++ w/dir.c...

https://github.com/nobu/ruby/tree/getwd_ospath

FYI: https://github.com/nobu/ruby/tree/opt_newarray_pack

Well, I did it just to see if possible, and no idea about RJit support yet. I'm OK if you want to take it over. Addition: IMO, rbinc method optimization...

The order is `assert_equal(expected, actual)`.