noblox.js
noblox.js copied to clipboard
Implemented getUniverseContainingPlace
I saw there was no api implementation for //api.roblox.com/universes/get-universe-containing-place so I implemented it. Sorry if this is a bad request since this my first pull request.
api.roblox.com is getting sunsetted soon i think, so this would only work for a little bit.
api.roblox.com is getting sunsetted soon i think, so this would only work for a little bit.
so if I implement the same thing without using api.roblox.com would it be better?
yes
yes
I don't think I will be able to since look at the APIs roblox doesn't seem like they're going to add a alterative to this endpoint. I will add a "fix" if I do find a alterative but might as well close this pr.
There is another API endpoint that ROBLOX has suggested using, which can accomplish the same task and more, with a caveat being you need to be authenticated to use it (from my testing at least).
https://games.roblox.com/docs#!/Games/get_v1_games_multiget_place_details, this can take in multiple placeId
's and always returns an array of objects with place data, that have their respective universeId
that the noblox.js user can utilize. Do think this warrants a new PR if implemented.
Utilizes deprecated endpoints; otherwise good first attempt at a PR.