noblox.js icon indicating copy to clipboard operation
noblox.js copied to clipboard

Implemented getUniverseContainingPlace

Open H3xad3cimalDev opened this issue 2 years ago • 5 comments

I saw there was no api implementation for //api.roblox.com/universes/get-universe-containing-place so I implemented it. Sorry if this is a bad request since this my first pull request.

H3xad3cimalDev avatar Jul 17 '22 16:07 H3xad3cimalDev

api.roblox.com is getting sunsetted soon i think, so this would only work for a little bit.

brandonapt avatar Jul 17 '22 16:07 brandonapt

api.roblox.com is getting sunsetted soon i think, so this would only work for a little bit.

so if I implement the same thing without using api.roblox.com would it be better?

H3xad3cimalDev avatar Jul 17 '22 16:07 H3xad3cimalDev

yes

brandonapt avatar Jul 17 '22 16:07 brandonapt

yes

I don't think I will be able to since look at the APIs roblox doesn't seem like they're going to add a alterative to this endpoint. I will add a "fix" if I do find a alterative but might as well close this pr.

H3xad3cimalDev avatar Jul 17 '22 16:07 H3xad3cimalDev

There is another API endpoint that ROBLOX has suggested using, which can accomplish the same task and more, with a caveat being you need to be authenticated to use it (from my testing at least).

https://games.roblox.com/docs#!/Games/get_v1_games_multiget_place_details, this can take in multiple placeId's and always returns an array of objects with place data, that have their respective universeId that the noblox.js user can utilize. Do think this warrants a new PR if implemented.

Aviation-7111 avatar Jul 19 '22 10:07 Aviation-7111

Utilizes deprecated endpoints; otherwise good first attempt at a PR.

alanbixby avatar Apr 27 '23 22:04 alanbixby