noblox.js icon indicating copy to clipboard operation
noblox.js copied to clipboard

"request has been deprecated" warning when installing noblox.js

Open Dreamurrrr opened this issue 4 years ago • 9 comments

Describe the issue When installing noblox.js, this following warning pops up in the install logs:

npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142

To Reproduce Steps to reproduce the behavior:

  1. Install noblox.js
  2. See warning

Expected behavior A clean install without any warnings.

Why this Issue is Important A future update of npm may break the install sequence for noblox.js.

Dreamurrrr avatar Jun 01 '20 04:06 Dreamurrrr

I'm currently working on a v5 rewrite that doesn't use request. This one will take a while.

suufi avatar Jun 02 '20 15:06 suufi

Usually this isn't a problem, the code should still work, as long as you don't get npm err, then the code will still work. It might be a problem in the future though.

iwl-lyam avatar Aug 20 '20 15:08 iwl-lyam

This usually refers to when you install older version I recommend to use: npm install noblox.js instead of downloading a specific version. F.Y.I. downloading the first version can cause some cookie issues as the cookie endpoint has changed. Since you are installing ver: 2 it will give you a deprecated warning as ver: 3 is (I believe) the newest. It is trying to tell you that noblox may not work properly.

Edit: This was a long time ago, now, not so much.

nottisa avatar May 13 '21 14:05 nottisa

If it works, it works.

ari-party avatar Nov 01 '22 23:11 ari-party

Why doesn't this noblox switch to using axios? It is a much more advanced and a more up to date library

royce-mathew avatar Jun 29 '23 18:06 royce-mathew

Still looking for help on this to migrate to using the built in Node.js Fetch API.

Neztore avatar Mar 24 '24 19:03 Neztore

I suggest we should migrate to fetch(). The API connections keeps getting left open, making noblox.js an unreliable source. My bots have been unreliable due to noblox.js using requests.

For example, once the bots start, the API will work without issue. However, due to recent issues with the request package since its been deperacated, connections have been being left open causing some noblox.js functions to not complete from time to time. For example, NBX.promote() or NBX.setRank().

This is an URGENT issue that needs to be resolved as there isn't really any other reliable package for my case.

Axcelers avatar Mar 26 '24 15:03 Axcelers

Still looking for help on this to migrate to using the built in Node.js Fetch API.

What parts of the noblox.js package use request? Is it only the http.js file in /lib/util?

Axcelers avatar Mar 26 '24 15:03 Axcelers