org-transclusion icon indicating copy to clipboard operation
org-transclusion copied to clipboard

Refactor/src lines

Open nobiot opened this issue 2 years ago • 3 comments

nobiot avatar May 08 '23 16:05 nobiot

@devcarbon-com I am trying to refactor src-lines.el. I feel that function org-transclusion-content-range-of-lines is too long and it does :lines and :thing-at-point -- I was hoping to separate them into their own functions.

I have tried this below, but it cannot find the thing boundary correct for defun and sexp. Do you see where I am wrong? sentence and paragraph seem to work OK. I am using test/things-at-point.org as the test.

https://github.com/nobiot/org-transclusion/blob/refactor/src-lines/org-transclusion-src-lines.el#L343-L381

nobiot avatar May 08 '23 16:05 nobiot

Hey @nobiot , I'll be happy to take a look, but so you know it will probably be a few weeks before I can.

devcarbon-com avatar May 12 '23 01:05 devcarbon-com

Timing is perfect 👍 Thank you!

nobiot avatar May 12 '23 06:05 nobiot