Noah Allen

Results 41 comments of Noah Allen

Unsure! I'll be investigating soon, as they shouldn't all be failing like that.

> What's with the failing e2e tests? I guess importing the profiler at all in production must have caused those issues? Now that we only import dynamically, it looks like...

Alright, all feedback should be addressed!

This is really interesting, thanks for working on it! My concern is that Sentry is by definition tied to the Calypso application. The config we have is specific to running...

Yeah, that's a good point. We did use filters for a similar use case (capturing Gutenberg errors within React error boundaries), but that was really the only viable solution for...

Ok! It's definitely an interesting problem. Maybe at some point we (@Automattic/team-calypso-platform) could think about how to have a sharable Sentry library which can connect to the running sentry instance...

Nice! What's the plan for supporting other plugins like ETK? Will those also be integrated into this script eventually?

> following the same pattern of having a build (or a single build, maybe integrate them all in one) for them! 👍 I think it could also be possible to...

I'd like to merge this on Monday if possible! @tyxla could you verify the logic changes? (In particular, do you think avoiding the redux cache for logged-in requests is a...

Oh nice. It looks like the hash file is present on my sandbox. I wonder if it reads in some whitespace or something.