Noah Fournier

to_commit not used

2

The `to_commit` field is not used anywhere but the commit(), \_\_enter__() and \_\_exit__() methods. Is this expected behaviour? I would assume that to_commit should be set to True in the...

Currently, offsetsForTimes is not working when using the mock broker: See [here](https://github.com/confluentinc/librdkafka/blob/465f81cee46255f29ea71f17ff90092100b1326c/src/rdkafka_mock_handlers.c#L506) I think this would be very valuable to test application-driven offset assignment logic. Happy to pick this up,...