Noah Dietz
Noah Dietz
Hey @loeffel-io, you are correct on both counts! I checked your boxes :) We need to change the rule code here: https://github.com/googleapis/api-linter/blob/2c8f81a6b6bbb8a7449a23d6219034d4439b987e/rules/aip0231/plural_method_name.go#L32-L37 to be `(google.api.resource).plural` aware (as per AIP-123) and...
I took a crack at it and updated some of the other batch methods to fix them as well.
@r9deyes I just remembered that we encountered the staticcheck deprecation warning in your PR #1436 and decided not to deal with it there, but I've just disabled that check in...
Yes you are understanding the question. I am mostly concerned if dependents of `api-linter` will end up seeing staticcheck `SA1019` warnings because `api-linter` was upgraded to a deprecated version of...
Yeah ok I just confirmed that since `jhump/protoreflect` appears in the api-linter API, dependents of api-linter (e.g. those that write their own rules) take a direct dependency on `jhump/protoreflect` and...
Considering we cannot easily move off of `jhump/protoreflect/desc`, I think it would be bad form to upgrade to the deprecated version in this repository. The only way we move off...
reverting and freezing this dep: https://github.com/googleapis/api-linter/pull/1449
Note: Some common type usage is recommended in more pertinent guidance e.g. the above `Interval` guidance is mentioned in AIP-145 already We should probably have some actual guidance written down...
> move them into the service config if they're so general that they should be configured through that mechanism. In general, I think the language-specific sections of the service config...