nntrainer icon indicating copy to clipboard operation
nntrainer copied to clipboard

[GPU/OpenCL] Broadcasting support added for GPU Addition kernel.

Open niket-agarwal opened this issue 1 year ago • 1 comments

Performing addition where dimensions of InputA and InputB vary. Added broadcasting support only where number of batches vary and other dimensions are same for both inputs. Number of batch of InputB must be 1. Output of add_i_cl(A,B) is stored in A inplace.

Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

niket-agarwal avatar Oct 17 '24 12:10 niket-agarwal

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2759. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

taos-ci avatar Oct 17 '24 12:10 taos-ci

PTAL: @baek2sm @skykongkong8 @EunjuYang

myungjoo avatar Oct 30 '24 01:10 myungjoo

Also, for you added new feature of broadcasting support for addition kernel, what about adding unit test for the case?

EunjuYang avatar Nov 18 '24 05:11 EunjuYang