nntrainer icon indicating copy to clipboard operation
nntrainer copied to clipboard

Weight sharing bug with is_dependent

Open kparichay opened this issue 3 years ago • 3 comments

Weight sharing assumes that all the tensors share the weights. Weight class contains is_dependent which tells if the weight is shared/dependent with other tensors or not. Lets assume 3 weights, W1, W2, W3, all sharing weights. Then W2 and W3 have is_dependent variable set to true, but W1 still contains is_dependent set to false.

kparichay avatar Nov 25 '21 10:11 kparichay

:octocat: cibot: Thank you for posting issue #1744. The person in charge will reply soon.

taos-ci avatar Nov 25 '21 10:11 taos-ci

I don't like it but as a quick fix, we can have

[layer 1] shared_from=layer_1

[layer 2] shared_from=layer_1

[layer 3] shared_from=layer_1

zhoonit avatar Nov 25 '21 11:11 zhoonit

works as a quick fix.

kparichay avatar Nov 25 '21 12:11 kparichay