transmission-rss icon indicating copy to clipboard operation
transmission-rss copied to clipboard

Published 20 hours ago • verified publisher icon nning

Support exclude filters

Open jntn-st opened this issue 5 years ago • 6 comments

This implements a new configuration option "exclude" for a regexp group. #29

jntn-st avatar Apr 21 '19 19:04 jntn-st

Coverage Status

Coverage remained the same at 100.0% when pulling 9a0cc9fc8468cd0c6dbe7a1f91271ab3088e9838 on jntn-st:excludefilters into 8c13dd87ce23d35ded993e9ff475d610ff4b0a04 on nning:master.

coveralls avatar Apr 21 '19 19:04 coveralls

@nning, just a friendly reminder to take a look at this PR.

jntn-st avatar Apr 30 '19 07:04 jntn-st

Thank you very much for your contribution! I just made some minor code styling comments and will test your feature after you made those changes. Would you also add tests, please (e.g. in spec/feed_spec.rb)?

nning avatar May 04 '19 07:05 nning

I can't find the code styling comments you are referring to. I'm quite new to github, so it may just be that I don't know where to look for them. Sure, I will add tests, it is a reasonable requirement.

jntn-st avatar May 04 '19 15:05 jntn-st

I'm sorry, I just realized, I did not submit my review. Would you please add tests? Thanks again for your contribution!

nning avatar Sep 24 '19 09:09 nning

When can we expect this pull request to be merged? It's a MUCH needed feature! :)

GnaXi avatar May 08 '20 21:05 GnaXi