Glenn Becker

Results 77 comments of Glenn Becker

This was implemented previously. Appears to be a regression. https://github.com/BuilderIO/qwik/issues/599

Won't be able to reproduce in the playground because it needs a layout.tsx to trigger the bug. @mastastealth has the minimal repro here https://github.com/mastastealth/qwik-context/commit/83d16aab40a88365e34e2ca7e030e77938b3c537 The important parts are src/routes/layout.tsx and...

Thanks for the update @zanettin! :rocket: @Oyemade @youngboy Have you tried building the Qwik repo lately? Is this still an issue for you?

Thanks @Oyemade! Looks like the issue is still present. 27 minutes seems a bit excessive. I think we just have to wait for wasm-pack to push a new version with...

I think the file you're looking for is here. https://github.com/BuilderIO/qwik/blob/main/packages/qwik/src/core/render/jsx/types/jsx-qwik-attributes.ts

Yeah, it's a little confusing in there. They are generated based here: https://github.com/BuilderIO/qwik/blob/main/packages/qwik/src/core/render/jsx/types/jsx-qwik-attributes.ts#L168 based on this type: https://github.com/BuilderIO/qwik/blob/main/packages/qwik/src/core/render/jsx/types/jsx-qwik-attributes.ts#L8

I'm wondering if a new api is acutally needed. It seems like the bigger issue is that cookies aren't being set correctly on the Response. If the cookie issue was...

I had @GuillemPM open this as a bug report because I wasn't sure if it was possible or could be possible. If it's expected behavior but possible in the future...

Not sure what's happening with the build error. Is `@public` not the correct tag for these type exports?