geometry-central icon indicating copy to clipboard operation
geometry-central copied to clipboard

Updating the functionality of barycentric vectors

Open nzfeng opened this issue 1 year ago • 1 comments

Nothing major -- just added additional functionality to the BarycentricVector object:

  • rotated90() now supports edge-type vectors as input
  • a new function rotated() allows rotation of vectors by arbitrary angles
  • added some more detailed comments in the code so I don't forget how I derived quantities :)
  • documentation updated accordingly.

Let me know if you need me to add additional test functions to geometry-central -- for these few commits, I tested everything using an external program: https://github.com/nzfeng/barycentric-vector-demo

nzfeng avatar Jan 31 '24 18:01 nzfeng

This looks great! Docs are good too. I left two small comments above, but neither are big issues, just small questions.

nmwsharp avatar Feb 04 '24 21:02 nmwsharp

@nzfeng just realized this was never merged, is it good-to-go on your end? if so we can hit the merge button

nmwsharp avatar Jul 22 '24 00:07 nmwsharp

Yes, it's good to go on my end! Edit: Just rebased on top of geometry-central's master branch.

nzfeng avatar Jul 24 '24 08:07 nzfeng

Awesome! thank you!!

nmwsharp avatar Jul 25 '24 00:07 nmwsharp

Docs are already updated here: https://geometry-central.net/surface/utilities/barycentric_vector/

nmwsharp avatar Jul 25 '24 00:07 nmwsharp