Nicolas Munnich
Nicolas Munnich
Hi, thanks for the PR. I just wanted to give a heads up that this is unlikely to be merged as-is. What ZMK really needs is a more general lighting...
I wanted to use said method while writing a west extension. The positioning of the method in the source code implies (to me at least) that it was intended to...
For boards, we typically rely on Zephyr. You can see a list of boards that Zephyr supports for our current version of Zephyr [here](https://docs.zephyrproject.org/3.5.0/boards/index.html#boards), and you can see the list...
I'd like to see a logging message added to this.
> This is being used as a workaround to what I consider to be a design flaw in the display code. Agree with this point. I'd like to see both...
Thanks again Pete for the reply. I have done some larger changes to accommodate. I think this version reads much nicer. Unfortunately a rename was involved which makes reviewing it...
Did some reshuffling to try and get the tabs behaving nicely without too much duplication. Since this required shoving a bunch of content into other files, I also did so...
Made the dts and general replacements.
Did a refactoring of this to make it cleaner (as was discussed previously on Discord). Originally I intended to do the refactor after this is merged, but as it has...
Folded the content from #2439 back into this - trying to get it nicely into separate PRs post development reshuffling was annoying me too much.