kubernetes-nmstate icon indicating copy to clipboard operation
kubernetes-nmstate copied to clipboard

managed-by label of nmstate-ca secret is wrong

Open RamLavi opened this issue 4 years ago • 1 comments

What happened: the managed-by label value of self deployed objects should not be inherited from CNAO/HCO CR.

$ kubectl get secret nmstate-ca -n kubevirt-hyperconverged -o custom-columns="":.metadata.labels

map[
app.kubernetes.io/component:network 
app.kubernetes.io/managed-by:hco-operator 
app.kubernetes.io/part-of:hyperconverged-cluster 
app.kubernetes.io/version:1.6.0
]

What you expected to happen: It must be app.kubernetes.io/managed-by: kubernetes-nmstate-webhook (pretty sure it's the webhook, right?)

How to reproduce it (as minimally and precisely as possible): deploy HCO/CNAO and take a look at the secret label.

Anything else we need to know?: similar to issue opened on CNAO https://github.com/kubevirt/cluster-network-addons-operator/issues/1051 Environment:

RamLavi avatar Nov 15 '21 22:11 RamLavi

Note please that are more entities such as enactments that are created by nmstate, so they need to be updated as well. Generally speaking we need to find and fix it for all the elements that were not directly deployed by CNAO

oshoval avatar Dec 21 '21 08:12 oshoval