kubernetes-nmstate
kubernetes-nmstate copied to clipboard
nmstate
test: add test for global DNS configuration
Is this a BUG FIX or a FEATURE ?:
/kind enhancement
What this PR does / why we need it:
Special notes for your reviewer:
Release note:
NONE
/test pull-kubernetes-nmstate-unit-test
It may be a valid issue
/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/musttag.go:4:2: unrecognized import path "go.tmz.dev/musttag": reading https://go.tmz.dev/musttag?go-get=1: 404 Not Found
But those servers are good, so they will not trigger the revert. If I read the current code correctly, we want the test to contain hardcoded wrong DNS server, that's why I used 192.168.100.3
/hold
This test is expected to fail until we have NM fixed. Currently it configures 192.168.100.3 (fake) and never rolls it back
Handler E2E Test Suite: [It] rollback when name servers (configured globally) are wrong after state configuration should rollback to previous name servers expand_less 14m8s
{Timed out after 480.000s.
should eventually lose wrong name server
Expected
<[]string | len:1, cap:1>: ["192.168.100.3"]
not to contain element matching
<string>: 192.168.100.3 failed [FAILED] Timed out after 480.000s.
should eventually lose wrong name server
Expected
<[]string | len:1, cap:1>: ["192.168.100.3"]
not to contain element matching
<string>: 192.168.100.3
In [It] at: /tmp/knmstate/kubernetes-nmstate/test/e2e/handler/rollback_test.go:262 @ 02/03/24 21:59:26.922
}
/retest
go: downloading golang.org/x/mod v0.4.2
/home/prow/go/pkg/mod/k8s.io/[email protected]/pkg/api/resource/amount.go:23:2: unrecognized import path "gopkg.in/inf.v0": reading https://gopkg.in/inf.v0?go-get=1: 502 Bad Gateway
server response: Cannot obtain refs from GitHub: timeout
/home/prow/go/pkg/mod/sigs.k8s.io/structured-merge-diff/[email protected]/value/value.go:26:2: unrecognized import path "gopkg.in/yaml.v2": reading https://gopkg.in/yaml.v2?go-get=1: 502 Bad Gateway
server response: Cannot obtain refs from GitHub: timeout
/home/prow/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/schemapatcher/gen.go:24:2: unrecognized import path "gopkg.in/yaml.v3": reading https://gopkg.in/yaml.v3?go-get=1: 502 Bad Gateway
server response: Cannot obtain refs from GitHub: timeout
make: *** [Makefile:134: gen-k8s] Error 1
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: qinqon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [qinqon]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kubernetes-nmstate-e2e-handler-k8s | e460a86f5d7321060e1fa725617f4521fe5e17b7 | link | true | /test pull-kubernetes-nmstate-e2e-handler-k8s |
| pull-kubernetes-nmstate-e2e-handler-k8s-future | e460a86f5d7321060e1fa725617f4521fe5e17b7 | link | false | /test pull-kubernetes-nmstate-e2e-handler-k8s-future |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.