kubernetes-nmstate
kubernetes-nmstate copied to clipboard
Refact probe timeouts
Is this a BUG FIX or a FEATURE ?:
Uncomment only one, leave it on its own line:
/kind bug /kind enhancement
What this PR does / why we need it: This PR chages the timeout logic, moving the retry responsibility out of the probe functions. This simplifies the probe func interface, as we don't need to pass a timeout parameter, and it's handled by the caller.
Additionally, some comments seemed unclear. Second commit of this PR attempts to improve those.
Special notes for your reviewer:
Release note:
NONE
/test pull-kubernetes-nmstate-e2e-handler-k8s-future
@rhrazdil: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-kubernetes-nmstate-e2e-handler-k8s-future | 21abe6023529d8c1075d8126c69326144e15ba8d | link | false | /test pull-kubernetes-nmstate-e2e-handler-k8s-future |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: qinqon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [qinqon]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment