kubernetes-nmstate icon indicating copy to clipboard operation
kubernetes-nmstate copied to clipboard

Use nmstatectl rust

Open qinqon opened this issue 2 years ago • 15 comments

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug /kind enhancement

What this PR does / why we need it: This PR use the rust version of nmstatectl to check for issues there, tt also remove error stripping since it's not needed at rust version.

the normal handler lane is pointing to stream9 nmstate while futur is pointing to stream9 copr nmstate-git

Depends on:

  • BZs:
    • ~~https://bugzilla.redhat.com/show_bug.cgi?id=2079420~~
    • ~~https://bugzilla.redhat.com/show_bug.cgi?id=2081277~~
    • ~~https://bugzilla.redhat.com/show_bug.cgi?id=2081286~~
    • ~~https://bugzilla.redhat.com/show_bug.cgi?id=2081356~~
    • https://bugzilla.redhat.com/show_bug.cgi?id=2089791
  • PRs:
    • https://github.com/nmstate/nmstate/pull/1881
    • https://github.com/nmstate/kubernetes-nmstate/pull/969
    • https://github.com/nmstate/nmstate/pull/1792
    • https://github.com/nmstate/nmstate/pull/1789
    • https://github.com/nmstate/nmstate/pull/1794
    • https://github.com/nmstate/nmstate/pull/1821
    • https://github.com/nmstate/nmstate/pull/1830
    • https://github.com/nmstate/nmstate/pull/1839
    • https://github.com/nmstate/nmstate/pull/1868
    • https://github.com/nmstate/nmstate/pull/1883

Release note:

Remove error stripping.

qinqon avatar Apr 21 '22 09:04 qinqon

/hold This is wip

qinqon avatar Apr 21 '22 09:04 qinqon

Looks like copr is broken and https://github.com/nmstate/nmstate/pull/1868 is not reaching nmstate-git

qinqon avatar Apr 21 '22 11:04 qinqon

/retest

qinqon avatar Apr 22 '22 14:04 qinqon

/retest

qinqon avatar Apr 25 '22 11:04 qinqon

/test pull-kubernetes-nmstate-e2e-handler-k8s-future

qinqon avatar Apr 26 '22 11:04 qinqon

/test pull-kubernetes-nmstate-e2e-handler-k8s-future

qinqon avatar Apr 26 '22 12:04 qinqon

Looks like copr nmstate-git is not able to put eth1 down at setup/teardown

 message: |-
      error reconciling NodeNetworkConfigurationPolicy at desired state apply: ,
       failed to execute nmstatectl set --no-commit --timeout 480: 'exit status 65' '' 'Using 'set' is deprecated, use 'apply' instead.
      NmstateError: VerificationError: Verification failure: eth1.interface.state desire '"down"', current '"up"'
      '

qinqon avatar Apr 26 '22 14:04 qinqon

After removing the bond of eth0 and eth1 (eth1 is up there) and checked that bond0 is going we have to add a 15 seconds sleep so we canreset the eth1 to down (looks like it's still trapped by the bond?).

qinqon avatar Apr 28 '22 07:04 qinqon

/retest

To check:

  • https://github.com/nmstate/nmstate/pull/1883

qinqon avatar May 04 '22 09:05 qinqon

/retest copr is fixed now.

qinqon avatar May 23 '22 05:05 qinqon

/test pull-kubernetes-nmstate-e2e-handler-k8s-future

qinqon avatar Jun 02 '22 10:06 qinqon

/retest

qinqon avatar Jun 03 '22 05:06 qinqon

/retest

qinqon avatar Jun 09 '22 09:06 qinqon

/rehearse

qinqon avatar Aug 29 '22 15:08 qinqon

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from qinqon by writing /assign @qinqon in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Oct 24 '22 12:10 kubevirt-bot

@qinqon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future 8180d7cfa9094cb707cab0d6590821508554f4cc link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future
pull-kubernetes-nmstate-e2e-handler-k8s 8180d7cfa9094cb707cab0d6590821508554f4cc link true /test pull-kubernetes-nmstate-e2e-handler-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kubevirt-bot avatar Oct 24 '22 14:10 kubevirt-bot

/test pull-kubernetes-nmstate-e2e-handler-k8s

NNCP with maxUnavailable when applying a policy to matching nodes
  should be progressing on multiple nodes
  /tmp/knmstate/kubernetes-nmstate/test/e2e/handler/nncp_parallel_test.go:60
[38;5;11mGinkgo received an interrupt signal but is currently running a ReportAfterEach
node.  To avoid an invalid report the ReportAfterEach node will not be
interrupted however subsequent tests will be skipped.[0m

qinqon avatar Jan 04 '23 06:01 qinqon

/retest

qinqon avatar Jan 10 '23 09:01 qinqon

Looks like CI is stuck whenever test access the cluster nodes.

qinqon avatar Jan 11 '23 11:01 qinqon

/test pull-kubernetes-nmstate-e2e-handler-k8s

qinqon avatar Jan 11 '23 15:01 qinqon

/retest

qinqon avatar Jan 13 '23 07:01 qinqon

/retest

qinqon avatar Jan 16 '23 07:01 qinqon

Let's check if the ovs test failures are deterministic /retest pull-kubernetes-nmstate-e2e-handler-k8s

qinqon avatar Jan 19 '23 09:01 qinqon

@qinqon: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

  • /test pull-kubernetes-nmstate-docs
  • /test pull-kubernetes-nmstate-e2e-handler-k8s
  • /test pull-kubernetes-nmstate-e2e-operator-k8s
  • /test pull-kubernetes-nmstate-unit-test

The following commands are available to trigger optional jobs:

  • /test pull-kubernetes-nmstate-e2e-handler-k8s-future
  • /test pull-kubernetes-nmstate-e2e-upgrade-k8s

Use /test all to run all jobs.

In response to this:

Let's check if the ovs test failures are deterministic /retest pull-kubernetes-nmstate-e2e-handler-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Jan 19 '23 09:01 kubevirt-bot

Looks like we are breaking default gw when we use a ovs-bridge + ovs-interface to replace the primary interface

{"level":"info","ts":"2023-01-18T14:26:03.948Z","logger":"probe","msg":"default gw missing","path":"routes.running.#(destination==\"0.0.0.0/0\").next-hop-address"}
{"level":"error","ts":"2023-01-18T14:26:03.948Z","logger":"probe","msg":"failed to retrieve default gw","error":"default gw missing","errorVerbose":"default gw missing

qinqon avatar Jan 27 '23 12:01 qinqon

/test pull-kubernetes-nmstate-e2e-handler-k8s

qinqon avatar Jan 31 '23 13:01 qinqon

/retest

qinqon avatar Feb 02 '23 16:02 qinqon

/test pull-kubernetes-nmstate-e2e-handler-k8s

qinqon avatar Feb 03 '23 08:02 qinqon

/retest

qinqon avatar Feb 28 '23 07:02 qinqon

/hold cancel

@cybertron @cathay4t we are ready to move to centos 9 stream

qinqon avatar Mar 06 '23 10:03 qinqon

/retest

qinqon avatar Mar 21 '23 11:03 qinqon

/retest

qinqon avatar Mar 21 '23 17:03 qinqon