hnswlib icon indicating copy to clipboard operation
hnswlib copied to clipboard

how to unmark_deleted

Open liding1990 opened this issue 3 years ago • 6 comments

is it possible to unmark_deleted?

liding1990 avatar Jan 29 '21 07:01 liding1990

Hi @liding1990, Yes, via C++ interface. Would people use if it were be in python?

yurymalkov avatar Jan 29 '21 20:01 yurymalkov

Thanks for the info, I think it would be logical to have the unmark_delete function in python🙌🏼

liding1990 avatar Feb 04 '21 05:02 liding1990

@yurymalkov I also have a use case , can you point me to the c++ code interface method as well , thanks

patelprateek avatar Jul 14 '21 07:07 patelprateek

@patelprateek I have started working on this.

dyashuni avatar Jul 22 '21 14:07 dyashuni

@patelprateek this https://github.com/nmslib/hnswlib/pull/334 should add unmark_deleted function in python

dyashuni avatar Jul 29 '21 14:07 dyashuni

@patelprateek this https://github.com/nmslib/hnswlib/pull/334 should add unmark_deleted function in python

I just found out that in version 0.5.2, the unmark deleted feature was exist. When use add_item function with an pre-existing mark_deleted label, add_item will work as "update_item" and "unmark_deleted" the label.

Perhaps the "add_item" name is misleading, but documentation on update function definitely needs more work.

liding1990 avatar Aug 04 '21 01:08 liding1990