hnswlib icon indicating copy to clipboard operation
hnswlib copied to clipboard

A typo

Open op-hunter opened this issue 4 years ago • 1 comments

I think it maybe a typo in file "space_l2.h" at line 225:

data_size_ = dim * sizeof(unsigned char);

why not:

data_size_ = dim * sizeof(int);

op-hunter avatar Jun 08 '20 09:06 op-hunter

Hi @op-hunter thanks for checking the code. I think this is as it should be. The method works with single-byte integers and returns 4-byte characters. Probably calling it L2SpaceI is a bit confusing. I'll update comments to lesser the confusion.

yurymalkov avatar Jun 27 '20 04:06 yurymalkov