Nathan Moinvaziri

Results 433 comments of Nathan Moinvaziri

You might want to make it configurable as mentioned in that PR discussion, that way if somebody is using it for web server connections they can set it to use...

Also, I have had some internal zlib-ng discussions about bypassing the pending buffer altogether in certain instances. But for `ZlibStream`, the API doesn't appear to allow for using `FlushMode` directly,...

> Lint fixed. Interesting solution.

Recent changes look good.

I think `PORTING.md` should be updated to indicate that we will always allocate enough memory for the max window size and the reason why.

It appears that it is not possible to trigger a custom build on a tag. The tag does show in the list of branches, but Travis doesn't treat it as...

This error, along with https://github.com/codecov/codecov-action/issues/1279, makes me think that changing from `openpgp` to `gpg` was a mistake.

@thomasrockhu-codecov I looked at the change log for 4.5.0, but didn't see any related changes. Can you point me to them?

https://github.com/madler/zlib/commit/ac8f12c97d1afd9bafa9c710f827d40a407d3266#r137966340

Yes please open a PR. There are some parts of the build I don't fully understand and expected this.