Nathan Moinvaziri

Results 433 comments of Nathan Moinvaziri

@shanselman were you able to get anywhere with the check? Thanks in advance.

According to https://github.com/MicrosoftDocs/win32/pull/1384, there is no guarantee that the certificate store returned by Microsoft will have the certificates in any relationship ordering, even though TLS may have its own ordering/relationship...

Curl already calls `QueryContextAttributes` with `SECPKG_ATTR_REMOTE_CERT_CONTEXT`, and then enumerates the certificates in the cert context buffer. The problem is that the chain ordering isn't consistent across versions of Windows. `SECPKG_ATTR_REMOTE_CERT_CONTEXT`...

> It's supposed to contain the "end certificate" and we already rely on that elsewhere as the server certificate. I think that the "end certificate/server certificate" (according to the MS...

>I have not been able to find anybody with local SChannel expertise. I had been discussing this with @alvinashcraft in https://github.com/MicrosoftDocs/win32/pull/1384#issuecomment-1370420956 and the response he got from his contacts at...

You are right in that respect. It would remove a few lines of code and an extra variable in `Adder_args` that was used to ensure a particular order.

Ok I will open a PR to revert that change. It should simplify the code a bit.