Noah Misch comments

Results 25 comments of


                                            Noah Misch

Prevent RepSetTableHash entry fields from being freed during invalidation callback

row_filter_sampling does fail trivially due to its expected output not having the test comment you added. With that fixed, things look good. In my testing against v14 (didn't try other...

pglogical.create_subscription and forward_origins parameters

Thanks for the report. A segfault is always a bug, indeed. I currently prioritize pglogical issues that have patches and where those patches include tests. Would you be willing to...

pglogical.create_subscription and forward_origins parameters

That's what I meant. No problem, but this may wait longer.

Fix sync worker hanging on Extension wait event after table resynchronization

At 9b36db7 (first version of pull request) add_table still timed out for me, but at bb85291 and 382d9cb it passes. It's great to have a fix for that. I see...

Fix sync worker hanging on Extension wait event after table resynchronization

Thanks. This is still in my queue. My schedule is unusually packed right now, so I likely won't be able to do a proper review for another few months, unfortunately....