android-tools icon indicating copy to clipboard operation
android-tools copied to clipboard

Add mkdtboimg tool

Open JamiKettunen opened this issue 2 years ago • 1 comments

This is a tool for packing multiple DTB/DTBO files into a single image which is used by bootloader on various Android devices since circa 2017.

libufdt is tracking tag platform-tools-31.0.3 as it stands, may have to be changed here or #65 depending on merge order.

Marking as draft for now till it's decided what should be done about the libufdt/utils/src/mkdtboimg.py #! /usr/bin/env python shebang; upstream already changed it on master branch but it's not yet tagged: https://android-review.googlesource.com/c/platform/system/libufdt/+/2061124/1/utils/src/mkdtboimg.py

JamiKettunen avatar Jul 21 '22 21:07 JamiKettunen

@nmeum Any comments? I'd like some feedback to get this merged eventually.

JamiKettunen avatar Sep 05 '22 22:09 JamiKettunen

@nmeum Any comments? I'd like some feedback to get this merged eventually.

I haven't looked into it yet, as I want to upgrade to 33.0.1 first. If you have the time, maybe consider helping out with the remaining compiler issue in #65 so we can move forward with this. My time to work an android-tools is unfortunately a bit limited right now.

If this tool is needed by pmOS, I am a also more than willing to give push access to more pmOS people.

nmeum avatar Sep 22 '22 11:09 nmeum

This is indeed already an extra package on postmarketOS: https://gitlab.com/postmarketOS/pmaports/-/tree/master/main/android-mkdtboimg

Unfortunately I don't think I have enough C++ understanding to fix a template error like what's seen in the upgrade PR :/

JamiKettunen avatar Sep 22 '22 11:09 JamiKettunen

@nmeum Rebased, the python3 shebang fix also was included in 33.0.3 so no need to potentially patch it here :)

JamiKettunen avatar Sep 23 '22 11:09 JamiKettunen

@nmeum Ping

JamiKettunen avatar Sep 28 '22 16:09 JamiKettunen

@nmeum I do not have objections to including this tool.

Are you OK to move forward with this PR?

anatol avatar Oct 10 '22 20:10 anatol