Nick Mathewson

I found this on the CFRG mailing list: it seems correct, and the tests still pass. See comment for references, including CFRG discussion. This improvement appears to have a modest...

Emit stderr from tests when running Tor in more cases.

1

When Tor is running as a daemon, its stderr is only used for real errors that we should probably be paying attention to. But there are still cases (see https://github.com/torproject/stem/issues/52#issuecomment-577932788)...

Use a faster safe bitwise rotate implementation.

3

This branch replaces the rotation operation with one that compiles down to a single branchless rotate instruction (on my gcc and clang compilers). The magic trick here is the fact...

Optimization: Use LIST_ instead of TAILQ_.

3

According to the queue(3) manpage, TAILQ "operations run about 20% slower than lists". So using LIST_ instead ought to make our code much faster. But this optimization comes at a...

Small optimization: remove needless code from internal sched() calls

2

When we call timeout_sched() internally, sometimes we can be sure that the timeout is in the future. Always, we can be sure that the timeout has its expires field and...

TIMEOUT_mHZ and friends seem wrong

1

The 'hz' argument is supposed to count frequency. But TIMEOUT_mHZ is not a millihertz; it is a kHz, which corresponds to a frequency of a millisecond. Similarly, TIMEOUT_uHZ is really...

Error message on previously nonexistent crate is a bit unhelpful

4

### Steps to reproduce the bug with the above code Run `cargo-semver-checks` on a workspace in which at least one crate has been created since the previous revision. ### Actual...

ux: Lack of key and origin in ConfigError::Message leads to uncertain sources from serde error messages

1

## Summary If a configuration error passes through a `serde::de::Error` implementation, it is wrapped as a `ConfigError::Message`, and information about what caused the error is not preserved. This confuses the...

Implement AsFd, AsRawFd, AsHandle, and AsRawHandle.

3

These traits can be leveraged to access an open LockFile for purposes like inspecting its metadata, or opening it as a File. Importantly, these traits can't easily be misused to...