Naveen Mahadevuni
Naveen Mahadevuni
@rschlussel Can you please review this?
@rschlussel Addresses all comments. Please review.
@pranjalssh : Thank you. Addressed the comments. Please review.
Thank you!
@yingsu00 : Could you please review?
@yingsu00 : Can you please review? The test native module is taking too long. The change to make the properties immutable needs some fair amount of refactoring. I will open...
Thanks @rschlussel @yingsu00 . Addressed the comments and updated the PR.
> @yingsu00 These `move`s are called on local variables only, not reference to the original type tree The input is modified when we assign the `parent_` in TypeWithId's constructor, the...
> @nmahadevuni I see, this is a very badly designed class. Can you > > 1. Change the constructor signature to take `std::vector children` so that we don't accidentally reparenting...
@yingsu00 @Yuhta I added a test which SEGVs without the fix. Please review again.