nlupugla

Results 24 comments of nlupugla

Great work! You love to see PRs with more lines removed than added that also speed performance :) I'll go through and review your changes in more detail when I...

Since the merging logic is non-trivial now, I might suggesting making a helper function or iterator that you can reuse for the different merge cases. For example, a `merge_vectors` method...

Wow, the new benchmarks show a bigger improvement and it seems like most of it is due to the `saving` somehow getting faster. It doesn't look like any of your...

Thanks for working on this @kitbev. I think this would make working with Arrays in the engine code much nicer. My only comment so far is whether we would rather...

Personally, I'd prefer the explicitness, but it might be an odd outlier if that's already how it works for some of the other types.

Re the loop example, I would say option 3 makes the most sense to me, ie: `1 2 2 2 2 2`. In the same way that the parser is...

Edit 2023/07/11 10:31am: clarified what I meant by "option 1". Out of curiosity, just tested the looping example in Python to see which of the three outputs it gave between...

Oh, I see what I did. When I said option 1, I meant option 1/3 of the poll, not option 1/2 as outlined in the summary. I'll edit my post...

I think it would be useful to see how more languages handle a similar situation. Normally, I would advocate for more help from the analyzer over less, but something feels...

Ah, I think I understand what's going on here. It is related to getting parse errors on account some GDScript settings: https://github.com/dialogic-godot/dialogic/pull/1975 Here's is what happens when the GDScript settings...