structured icon indicating copy to clipboard operation
structured copied to clipboard

Possible children are not concatenated when forming updated semantic vector

Open elisaF opened this issue 6 years ago • 0 comments

Equation (18) of the paper shows that children are also concatenated when forming the updated semantic vector. image

However, the code at this line only concatenates pi and ei, as far as I can tell. What about the children? Am I missing something? https://github.com/nlpyang/structured/blob/015e9d496dda5d74dbca81118f20b9f4be5b53c9/models.py#L151

Thanks! Elisa

elisaF avatar Apr 04 '18 18:04 elisaF