gnome-shell-extension-another-window-session-manager icon indicating copy to clipboard operation
gnome-shell-extension-another-window-session-manager copied to clipboard

Compatibility fix for Gnome 46

Open mendres82 opened this issue 1 year ago • 3 comments

Running this extension with Gnome 46 on openSUSE Tumbleweed gave me an error. Fortunately, it was quite easy to get around the issue. I just had to edit indicator.js and change lines 297 and 298 from add_actor to add_child .

mendres82 avatar Mar 23 '24 08:03 mendres82

Sorry to butt in, but you could just make a pull request with the changes. :p

MorbidShell avatar Mar 27 '24 07:03 MorbidShell

I created the pull request.

mendres82 avatar Mar 27 '24 22:03 mendres82

#104 works also with Fedora 40. After adjusting shell-version in metadata.json and re-login the extension works well

cmeissner avatar May 02 '24 22:05 cmeissner

While this fix works (changing lines 297 and 298 and fixing the shell-version in metadata.json), it seems to break session logout. When the logout dialog appears, clicking logout does nothing. You can still logout using gnome-session-quit -force, but that's not ideal. Disabling the extension restores normal logout behavior, so it does seem to be related to the extension.

OsoRojo avatar May 12 '24 17:05 OsoRojo

..., it seems to break session logout. When the logout dialog appears, clicking logout does nothing. You can still logout using gnome-session-quit -force, but that's not ideal.

Cannot reproduce on openSUSE Tumbleweed (Gnome 46.1) and Slowroll (Gnome 46.0). Both on Wayland.

mendres82 avatar May 13 '24 09:05 mendres82

..., it seems to break session logout. When the logout dialog appears, clicking logout does nothing. You can still logout using gnome-session-quit -force, but that's not ideal.

Cannot reproduce on openSUSE Tumbleweed (Gnome 46.1) and Slowroll (Gnome 46.0). Both on Wayland.

Just reproduced on a clean Fedora 40 Silverblue VM (Gnome 46.1 on Wayland) with no other extensions installed and the above mods in place. Note that the original report was not from Silverblue, but desktop proper with the same versions.

Disabling the plugin restores normal behavior.

Sorry, should have noted the distro I guess.

OsoRojo avatar May 13 '24 12:05 OsoRojo

While this fix works (changing lines 297 and 298 and fixing the shell-version in metadata.json), it seems to break session logout. When the logout dialog appears, clicking logout does nothing.

Hi, a new version that supports Gnome 46 has been approved, could you please test it again after updating? I think it might be fixed.

nlpsuge avatar May 18 '24 10:05 nlpsuge

So it's... sort of fixed, yes. I get the standard "you will be logged out after 60 seconds"...

image

And then after clicking logout via AWSM, I get this:

image

Clicking Logout Now DOES log me out, so that's good. But there are no other applications listed, and I don't have anything running but Software and Extensions. It's something I've never seen before.

To be clear, it's not a huge problem. It does allow both logout and reboot after it comes up, but the fact that no applications are listed seemed a bit odd. If this is just what we have to do now for some known reason I'm totally fine with that.

Thoughts?

OsoRojo avatar May 18 '24 14:05 OsoRojo

@sadamczyk @OsoRojo I've uploaded a new version that fixes the issue you mentioned. I'm waiting for it to be approved.

nlpsuge avatar May 20 '24 18:05 nlpsuge

Verified fixed on clean Silverblue VM for both logout and reboot! Thank you!!

OsoRojo avatar May 21 '24 15:05 OsoRojo