Nuno Loureiro

Results 58 comments of Nuno Loureiro

@raxhvl, thank you for your contribution! I made a version more aligned with the overall style of the map image. What do you think? ![map-of-erc-4626](https://github.com/ethereum/ethereum-org-website/assets/1120748/b9f634e9-92ff-4308-b1e7-6b49da7bc153) If everything is ok with...

> @nloureiro I love it!. A small fix: `convertToShares` and `convertToAssets` must be marked `MUST round down towards 0` and NOT `MUST NOT revert`. > > When you are done...

@raxhvl sorry... I saw it on a good display and realized I should have exported 2x the size. Can you stitch with this one? 🙌

> @nloureiro. Done! Quick heads up the resolution has increased but the image size is actually smaller 70 kb vs 77kb from earlier. yes, no worries. 77kb is still a...

Thank you @TylerAPfledderer I'm not sure where to give feedback on the chromatic part. Here or on the chromatic side? But for the dev preview link, I found some adjustments...

> > Thank you @TylerAPfledderer > > I'm not sure where to give feedback on the chromatic part. Here or on the chromatic side? > > But for the dev...

> Like the idea @nloureiro. > > This component has fairly unique behaviour on mobile. Do you propose keeping it the same? yes, I would say that it's working well...

> @nloureiro I would like to help with this one Awesome. it's yours :) Let me know if you need any help. Thank you

> @nloureiro Are you proposing we _move_ the component (remove from `/vision`)? Or duplicate it's use (both pages)? Just expressing caution against reusing the exact same copy which can hurt...

> If this is still pending, may I please take this up? Yes. I guess... @altinocoelho, do you have any updates? Can we pass it over to @reetbatra ? The...