Norberto Lopes

Results 43 comments of Norberto Lopes

Apologies @Fishrock123 but I merged a PR that improved things a bit with `reqwest` (in terms of dependencies) but that will force you to rebase. I also noticed that tests...

Indeed it is. I'll take a look at this - has been a while. I _think_ when I first took a stab at the lib async wasn't stable.

@ramosbugs apologies for such a long delay. I promise I'll look at this as soon as I'm not swamped. I appreciate the contribution!

Although I didn't have the intention to expose async outside of the client, I kind of like the approach here. Would you be so kind as to run `cargo readme...

The main thing I'd like to change before I merge (if you're up for it!) is to make `async-std` and `tokio` features that can be toggled. Your change here adds...

> it feels like runtime-agnostic primitives like async_std::future::timeout and async_std::sync::Mutex are preferable You hit exactly what my message was intended to deliver and which I failed to deliver 😆 That's...

This is looking great. I'm going to do a deeper review this weekend and get this out there most likely. I can't thank you enough for the contributions and patience...

Thank you for opening this @ramosbugs. Will take a look this weekend time permitting.

Hi @ramosbugs, apologies for the delay, haven't had the chance to look into this. The approach looks good. If you'd like to put in a PR before I get to...