json icon indicating copy to clipboard operation
json copied to clipboard

Use the provided allocator in destroy() (#4842)

Open veselink1 opened this issue 6 months ago • 5 comments

Uses the provided allocator to allocate the stack used to avoid recursion in the destroy() implementation used by ~basic_json.

This addresses issue #4842, by changing the std::vector to use the user-provided allocatorl

veselink1 avatar Jul 04 '25 11:07 veselink1

Coverage Status

coverage: 99.19%. remained the same when pulling ff3eaf8963647b08d4d8e57719d20ce9743ee8cc on veselink1:develop into d33ecd3f3bd11e30aa8bbabb00e0a9cd3f2456d8 on nlohmann:develop.

coveralls avatar Jul 04 '25 12:07 coveralls

This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions!

github-actions[bot] avatar Aug 04 '25 00:08 github-actions[bot]

Please rebase to the latest develop branch to have a green CI.

nlohmann avatar Aug 07 '25 05:08 nlohmann

This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions!

github-actions[bot] avatar Sep 07 '25 00:09 github-actions[bot]

This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions!

github-actions[bot] avatar Nov 23 '25 00:11 github-actions[bot]