json icon indicating copy to clipboard operation
json copied to clipboard

add strict enum de/serialization macro

Open hnampally opened this issue 10 months ago • 5 comments

#3992

  • [X] The changes are described in detail, both the what and why.
  • [X] If applicable, an #3992 is referenced.
  • [ ] The Code coverage remained at 100%. A test case for every new line of code.
  • [X] If applicable, the documentation is updated.
  • [X] The source code is amalgamated by running make amalgamate.

Read the Contribution Guidelines for detailed information.

hnampally avatar Jan 20 '25 04:01 hnampally

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @hnampally Please read and follow the Contribution Guidelines.

github-actions[bot] avatar Jan 20 '25 04:01 github-actions[bot]

Coverage Status

coverage: 99.186%. remained the same when pulling 6747555bc736852f487487d670ca4b4bf521b6ea on hnampally:issue-3992 into 606b6347edf0758c531abb6c36743e09a4c48a84 on nlohmann:develop.

coveralls avatar Jan 20 '25 05:01 coveralls

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @hnampally Please read and follow the Contribution Guidelines.

github-actions[bot] avatar Jan 26 '25 22:01 github-actions[bot]

It looks like you have a space in your filename here: docs/mkdocs/docs/api/macros/nlohmann_json_serialize_enum _strict.md

Also, the discussion about strings vs arbitrary json for the value has been marked outdated because there was a change in the file. @nlohmann did you see that discussion?

gregmarr avatar Jan 31 '25 17:01 gregmarr

This looks particularly useful, I was surprised by the behavior of the default enum serialization macro. Thanks for putting this PR up btw @hnampally

jmonticelli avatar Apr 01 '25 19:04 jmonticelli