nix2container icon indicating copy to clipboard operation
nix2container copied to clipboard

Improve image-pulling Nix functions

Open m-bdf opened this issue 7 months ago • 1 comments

  • Rewrite the buildImageBlob script in pullImageFromManifest to support more registries (e.g nvcr.io doesn't return a service= param in its WWW-Authenticate header)
  • Add cacert to nativeBuildInputs to use its setup hook instead of explicitly setting SSL_CERT_FILE in pullImage and buildImageBlob
  • Other small improvements in Nix code

Better reviewed commit by commit :)

m-bdf avatar May 23 '25 15:05 m-bdf

@mikepurvis since you contributed this pull method, could you try this branch in your environment to ensure there is no regression?

Thanks for the ping! I'm actually not at that company any more, so I'm not in a good position to validate it.

Overall looks good though, a bunch of nice bits of cleanup.

mikepurvis avatar Jun 02 '25 23:06 mikepurvis

Fixed! All workflows are now passing

m-bdf avatar Oct 28 '25 17:10 m-bdf

Thank you all for these nice improvements!

nlewo avatar Oct 29 '25 05:10 nlewo