hydra-cli icon indicating copy to clipboard operation
hydra-cli copied to clipboard
verified publisher icon nlewo

feat: while jobset-wait retry on hydra failures

Open amerocu opened this issue 2 years ago • 2 comments

While waiting for a jobset to complete, sometimes network requests can fail for many reasons. In these cases, the CLI will retry for 5 times in one minute, instead of just failing.

amerocu avatar Oct 01 '23 17:10 amerocu

Oops, I just saw the value of max_retries is hard-coded. I guess you can disregard most of my review :)

414owen avatar Oct 02 '23 08:10 414owen

I see your points, it would be better to have those parameters configured from outside, but given that we already have the sleep value hard-coded I tried to set reasonable defaults, and keep the MR small.

I think we can tackle the point of making this command more configurable and still keep these defaults. Would also be interesting to have dynamic seeps depending on the state of the jobset. Given how much jobset-wait does, it could make sense to just manage the sleeps automatically instead of having fixed parameters from the user.

amerocu avatar Oct 02 '23 10:10 amerocu