Nikhil Saraf
Nikhil Saraf
Thanks for this! I have been reconsidering this approach since I added it and basically was waiting for some feedback. This is very helpful, and im gonna think about a...
Can we add some integration tests for this.. we can create a route with a component that renders the error message and status code in the JSX (you can catch...
What was the problem with the tests? maybe I could help u debug.. check this guide out: https://github.com/solidjs/solid-start/blob/main/CONTRIBUTING.md
Yeah we need to do something about the externalizing logic for two reasons: 1. Make it consistent across dev/prod between vite and rollup as mentioned by @katywings 2. Automatically mark...
Thats a good point, we need to make the DX around this better
I thought we did do that , but I also think we set it incorrectly to `>=14`
This comment has a bunch of good ideas so copying here for reference https://github.com/solidjs/solid-start/issues/17#issuecomment-910268836 > Just my two cents here on the static adapter. This is an adapter I am...
The CI is failing.. could you see why? You can run the tests locally by running `pnpm run test` in the monorepo
@ryansolid, @rturnq can you look at this? why would this be happening?
What would cause this bug, the hackernews demo is the same one we have always had