Nick Png
Nick Png
blocked by: https://github.com/h2oai/mojo2/pull/850
@orendain fyi, separated pr for implementation of image scoring api in local-rest-scorer.
@orendain PTAL, I made a change which I like a bit more. Does not require any changes to api and actually allows the user to receive some message from errors.
@orendain thanks for taking a look! wrt to your comments. I didn't really try to make the messaging any better per say... just actually make the messaging go to the...
@orendain do you think it would make sense to have a generated swagger object `ErrorResponse`? For me it seems like maybe overengineering?
> Effectively, we're introducing a new feature: returning the full interpretation of a user's request, along with the raw underlying exception message. Depending on who you ask, returning these values...
@Susankha I would probably suggest that this go here: https://github.com/h2oai/dai-deployment-examples , unless it is expected to respect the api defined in our `common/swagger.yaml` definitions.
@Susankha again, I would strongly suggest this go into the other repo https://github.com/h2oai/dai-deployment-examples here. It is much better suited for this pr. cc @mmalohlava
> I think there are a few issues here: 1. this pr seems to be fully in python. Given this repo is nearly 100% java, I don't like the idea...
cc @mmalohlava @achraf-mer