Nikola Kovacs

Results 45 comments of Nikola Kovacs

Probably because of this change: https://golang.org/doc/go1.8#encoding_json

Also, regarding tests, I don't fully understand how they work, do i have to add my new fixtures to [roundtrip_test.go](https://github.com/maxbrunsfeld/counterfeiter/blob/master/integration/roundtrip_test.go#L184)?`scripts/ci.sh` runs go generate on the fixtures and then checks if...

That's the EAGAIN error which should be caught by poll, and it shouldn't matter if you're using `bufio.ReadString` or just plain `Read`: https://github.com/golang/go/blob/release-branch.go1.12/src/internal/poll/fd_unix.go#L168 What operating system are you using? Maybe...

The poller was implemented for files in Go 1.9. One option is to use build tags and then use blocking mode in Go

From the perspective of your program, the read will still be blocking (with Go 1.9+), because the poller will handle all that (while the file is actually in non-blocking mode)....

Yes, I think using non-blocking mode with the poller is the way to go. You can assume Go > 1.9, the issue is that the poller might not initialize in...

Ok, so the issue seems to be with the interpolation subpattern having the same name: https://github.com/genoma/language-pug/blob/f1f1610222a9f14f0a95fdffcd579a6e4cb64b42/grammars/pug.cson#L1096 It looks like this prevents the `tag_name` pattern from ending correctly, because if I...

Might be this: Endpoints MAY choose to generate a connection error (Section 5.4.1) of type INADEQUATE_SECURITY if one of the cipher suites from the black list is negotiated. https://tools.ietf.org/html/rfc7540#section-9.2.2 https://tools.ietf.org/html/rfc7540#appendix-A...

If you've updated gls and you're still getting this, delete $GOPATH/pkg/linux_amd64 (or whatever your OS/arch is). I had a vendored version of gls in there in one of my projects.