Nisha Nair
Nisha Nair
@krassowski any comments/suggestions for this PR? Its been a while. wondering how to proceed.
@krassowski I have updated the PR with all the changes we discussed above. Request for a re-review.
@krassowski The `jp-button` role problem is something that affects a lot of components. So we need an issue for this. After that we can merge and close both issues.
> Can you create a new issue for `jp-button`? Sure will do. Thanks for merging.
@krassowski I realized that we haven't closed the original accessibility issue with this PR merge as the button ariaLabel issue reported there still persists. Could we work on the suggested...
@RRosio The JupyterLab [issue](https://github.com/jupyterlab/jupyterlab/issues/16888) has been closed as a false positive for the tool. But please note that the issues mentioned here reference different areas of the UI. So these...
Tested on Notebook v7.4.7 and still see these issues reported.
Re-tested on Notebook v7.4.7. All issues still exists. The description has been updated to reflect the latest scans. ****Violation of Rule:** `aria_attribute_valid`** > > **Issue 1** > > **Issue 2**
Thanks, @Darshan808, for the review. I am looking into fixing the tests. Will update the PR soon.
The tests are now fixed and the one failure showing seems to be due to a timing issue. Please review.