python-ecobee-api icon indicating copy to clipboard operation
python-ecobee-api copied to clipboard

Add support for ecobee smart sensors for doors and windows

Open Maharshi-Pathak opened this issue 3 years ago • 1 comments

Hi I would like to contribute to this repo and collaborate with you to introduce the capability to add the door and window smartsensors into Ecobee integration directly. Since, these are only occupancy (remote) sensors and not thermostats, currently the ecobee integration does not recognize them as binary sensors. In my understanding this is due to the way the ecobee API calls are made in the get_remote_sensors() function i.e. self.thermostats[index]["remoteSensors"]. Please let me know if this something you have on your to do list already or you'd like to discuss more on this to get the ball rolling on this.

Maharshi-Pathak avatar Jun 14 '21 18:06 Maharshi-Pathak

I have no plans to add it, but I would welcome a PR. Thanks

On Mon, Jun 14, 2021 at 2:42 PM Maharshi-Pathak @.***> wrote:

Hi I would like to contribute to this repo and collaborate with you to introduce the capability to add the door and window smartsensors into Ecobee integration directly. Since, these are only occupancy (remote) sensors and not thermostats, currently the ecobee integration does not recognize them as binary sensors. In my understanding this is due to the way the ecobee API calls are made in the get_remote_sensors() function i.e. .get(ecobee.thermostats). Please let me know if this something you have on your to do list already or you'd like to discuss more on this to get the ball rolling on this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nkgilley/python-ecobee-api/issues/68, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALQBKW7KCFWENCECSRBHBDTSZESDANCNFSM46VYPDPQ .

nkgilley avatar Jun 14 '21 19:06 nkgilley