nkdengineer

Results 272 comments of nkdengineer

## Proposal ### Please re-state the problem that we are trying to solve in this issue. Migrate withReportAndPrivateNotesOrNotFound from withOnyx to useOnyx ### What is the root cause of that...

## Proposal ### Please re-state the problem that we are trying to solve in this issue. - Android - Thread-Mention phone number on reply thread shows expensify.sms in header ###...

@rayane-djouah PR https://github.com/Expensify/App/pull/39994 is ready to review

As I mentioned in the PR, we need to consider the case: User sends message "test message [email protected]" directly, If we apply the main solution, it will be "test message...

Sorry @anmurali It seems I wasn't paid here, could you please reopen the issue to help with this? TIA

## Proposal ### Please re-state the problem that we are trying to solve in this issue. - Group chat - User can proceed without Start group button via CMD+Enter shortcut...

@jjcoffee PR https://github.com/Expensify/App/pull/39553 is ready to review

## Proposal ### Please re-state the problem that we are trying to solve in this issue. - Mention - @expensify.sms is copied along with phone number when copied to clipboard...

@GandalfGwaihir Your main proposal and my alternative solution is different. Your proposal will use removeSmsDomain in here: https://github.com/Expensify/App/blob/91d7eb22b3cf0e690271a1313bf8016d03cb3ef7/src/pages/home/report/ContextMenu/ContextMenuActions.tsx#L345 My proposal will use removeSmsDomain in here: https://github.com/Expensify/App/blob/14ff9445d22bd92d0645abd456ac805cedc06c28/src/pages/home/report/ContextMenu/ContextMenuActions.tsx#L346

@alitoshmatov I updated my proposal based on [comment](https://github.com/Expensify/App/issues/38187#issuecomment-2030472999)