Noémien Kocher

Results 27 issues of Noémien Kocher

When the validation service executes a smart contract, there should be a timeout to prevent a malicious contract from blocking the node.

enhancement

We need to replace `sign/bls` with `sign/bdn`. This concerns `crypto/bls/mod.go`.

enhancement

Staticcheck outputs some deprecated warning that will have to be adressed: ```sh staticcheck ./... internal/testing/mod.go:8:2: package github.com/golang/protobuf/descriptor is deprecated: See the "google.golang.org/protobuf/reflect/protoreflect" package for how to obtain an EnumDescriptor or...

bug

We should make the join action thread safe, so that concurrent calls to it does not make problems. Got some errors of "invalid certificates"/"could not contact node" because of this.

bug
wontfix
mod/mino/grpc

This would remove some weird dependencies, like in core/txn.

design/architecture
mod/crypto

The Pool module is using `validation.Leeway`, that would be nice to find a way to remove that dependency.

design/architecture

Right now the `ordering/cosipbft` is defining its own `ordering/cosipbft/blocksync` abstraction. Syncing blocks is something that should be common to the ordering service, thus this abstraction should be moved to `ordering/`....

mod/ordering
design/architecture