ghostkit icon indicating copy to clipboard operation
ghostkit copied to clipboard

Save background custom colors as class and not hex inline style

Open spencer-j opened this issue 5 years ago • 1 comments

At the moment for example gutenberg custom background colors are saved as inline style with hex value of div .nk-awb-overlay Element. Maybe its more consistent and better to do it corresponding with the gutenberg default blocks (Group, Cover, paragraph ...) do it – with classes "has-background has-colorname-background-color" What do you think Greets spencer

spencer-j avatar Feb 18 '20 14:02 spencer-j

Hi Spencer.

I thinking about this feature before, but I still don't know how to make it properly. Gutenberg uses 2 classes only - for text color and for background color.

In Ghost Kit used also Borders, Shadows. Also, we use Hover and Focus styles. We can't add just text or background color classes, we will need to generate other classes too.

I don't have a good solution for now.

Regards, nK.

nk-o avatar Feb 26 '20 12:02 nk-o